Ocliam fixed this a typo or something

players.json

@@ -1,10 +1,11 @@
 {
     "expansions":
     {
-        "ShockColar1": {"players": ["Brosef"], "tags": ["shock"], "config": {"COM_port": "COM3", "shocker_ID": 24770}},
-        "RobotBarman": {"players": ["Tango", "TRS_MML"], "tags": ["drink"], "config": {}},
-        "ChallengeDB": {"players": ["TRS_MML"], "tags": ["challenge"], "config": {}},
-        "SourCandy": {"players": [], "tags": ["food"], "config": {}}
+        "ShockColar1": {"players": ["Brosef"], "tags": ["shock"], "class": "serialShocker", "config": {"COM_port": "COM3", "shocker_ID": 24770}},
+        "RobotBarman": {"players": ["Tango", "TRS_MML"], "tags": ["drink"], "class": "bar", "config": {}},
+        "ChallengeDB": {"players": ["TRS_MML"], "tags": ["challenge"], "class": "challenge", "config": {}},
+        "SourCandy": {"players": [], "tags": ["food"], "class": "candy", "config": {}},
+        "Simple": {"players": ["Brosef"], "tags": [], "class": "simplest", "config": {}}
     },
     "players": {
         "Brosef": {"flags": [], "expansions": {"exampleExpansion": {"playerOption": 5}}, "gamesSave": {"gameID0": 2}},

src/NoPELib/expansionsLib.py

@@ -6,7 +6,7 @@ import copy
 from typing import TYPE_CHECKING
 
 if TYPE_CHECKING:
-    from NoPELib.player_settings import ExpansionsManager
+    from .player_settings import ExpansionsManager
 
 
 class Hook:
@@ -37,30 +37,45 @@ class Expansion:
         players (tuple of str): 
         tags (tuple of flag): 
         config: The config of the expansion. Can't be modified during execution.
-
+    
     Methods:
+        __call__: Execute a given action with the expansion
+
+    Subclass methods:
         step: 
         reset: 
         close: 
     
     Signals:
-        onError: 
+        midStepError: 
     """
 
     def __init__(self, ID: str, expansionsManager: "ExpansionsManager"):
-        """
-        Initialise the creation of an expansion and raise an error if not
-        available.
-        """
         self._ID = ID
+        self._closed = False
         self._manager = expansionsManager
-        self.onError = Hook()
-    
+        self.midStepError = Hook()
+        self.midStepError.connect(expansionsManager._midStepError)
+
+    def __call__(self, action):
+        try:
+            assert not self._closed, "Can't use an expansion that has been closed."
+            return self.step(action)
+        except Exception as e:
+            step_info = {
+                "expansionID": self._ID,
+                "showOnScreen": None,
+                "error": e,
+                "done": False
+            }
+            self.midStepError(self._ID)
+            return step_info
+
     @property
     def config(self):
         """
         The config of the expansion.
-        NOTE Can't be modified during execution.
+        Can't be modified during execution.
         """
         return copy.deepcopy(self._manager.config[self._ID]["config"])
 
@@ -71,11 +86,11 @@ class Expansion:
 
     @players.setter
     def players(self, newPlayers):
-        self._manager.expansionPlayersChanged(self._ID, newPlayers)
+        self._manager.expansionPlayersChange(self._ID, newPlayers)
 
     @players.deleter
     def players(self):
-        self._manager.expansionPlayersChanged(self._ID, ())
+        self._manager.expansionPlayersChange(self._ID, ())
 
     @property
     def tags(self):
@@ -115,12 +130,12 @@ class serialShocker(Expansion):
         super().__init__(ID, expansionsManager)
         if self.config["COM_port"] not in serialShocker._api:
             self._assignApi()
-        self.shocker = serialShocker._api[self.config["COM_port"]].shocker(["shocker_ID"])
-    
+        self.shocker = serialShocker._api[self.config["COM_port"]].shocker(self.config["shocker_ID"])
+
     def _assignApi(self):
         from pishock import SerialAPI
         serialShocker._api[self.config["COM_port"]] = SerialAPI(self.config["COM_port"])
-    
+
     def step(self, action):
         """
         Arguments:
@@ -129,28 +144,22 @@ class serialShocker(Expansion):
             a positive float that defines the duration
             a float within the range [0.0, 1.0] that defines the intensity
         """
+        # Execute the step
         vibrateInstead, duration, intensity = action
         callFunc = self.shocker.vibrate if vibrateInstead else self.shocker.shock
-        # Try to execute the step
-        try:
-            callFunc(duration=duration, intensity=intensity)
-            error = None
-            done = True
-        except Exception as e:
-            error = e
-            done = False
+        callFunc(duration=duration, intensity=intensity)
         # Return additionnal info
         step_info = {
             "expansionID": self._ID,
             "showOnScreen": None,
-            "error": error,
-            "done": done
+            "error": None,
+            "done": True
         }
-        return step_info 
+        return step_info
 
     def close(self):
         pass
-    
+
     def reset(self):
         if self.config["COM_port"] not in serialShocker._api:
             serialShocker._api[self.config["COM_port"]].restart()
@@ -172,26 +181,20 @@ class simplest(Expansion):
             a positive float that defines the duration
             a float within the range [0.0, 1.0] that defines the intensity
         """
+        # Execute the step
         vibrateInstead, duration, intensity = action
         values = f"duration={duration}, intensity={intensity}"
         interact_type = "Vibrate" if vibrateInstead else "Shock"
-        # Try to execute the step
-        try:
-            message = f"{interact_type} with {values}"
-            error = None
-            done = True
-        except Exception as e:
-            message = None
-            error = e
-            done = False
+        message = f"{interact_type} with {values}"
+        print(message)
         # Return additionnal info
         step_info = {
             "expansionID": self._ID,
             "showOnScreen": message,
-            "error": error,
-            "done": done
+            "error": None,
+            "done": True
         }
-        return step_info 
+        return step_info
 
     def close(self):
         print("Closing")

src/NoPELib/player_settings.py

@@ -6,7 +6,7 @@ import copy
 import json
 import logging
 from pathlib import Path
-import NoPELib.expansionsLib as expansionsLib
+from . import expansionsLib
 
 _log = logging.getLogger('NoPE-Lib')
 
@@ -233,21 +233,20 @@ class ExpansionsManager:
     Manager of the availability of the expansions.
 
     Attributes:
-    includedExpansions: tuple of str
+    includeExpansions: tuple of str
         Container of the expansions to try making available
     activeExpansions: dict of Expansion
         Container of the relevent expansions
     
     Methods:
-    expansionPlayersChanged
+        expansionPlayersChange: Change the assigned players of an expansion
+        lookupPlayer: Provide a list of expansion available to a player
     """
     defaultExpansionConfig = {"players": (), "types": ()}
-    keysConvert2Tuple = ("players", "types")
+    keysConvert2Tuple = ("players", "tags")
     tags = ["shock", "spice", "sour", "drink", "challenge"]
-    # (attributed players / types)
-    # TODO Allow to get a list of expansions with a specific tag/player
 
-    def __init__(self, playersManager: PlayersManager, includedExpansions: tuple[str]=None):
+    def __init__(self, playersManager: PlayersManager, includeExpansions: tuple[str]=None):
         """
         Arguments:
         tryInclude: bool=False, tryActivate: bool=False
@@ -256,19 +255,23 @@ class ExpansionsManager:
         self.playersManager = playersManager
         self._playersLookUp = {}
         self._cfg = playersManager.config["expansions"]
-        if includedExpansions is not None:
-            self._includedExpansions = tuple(includedExpansions)
+        if includeExpansions is not None:
+            self._includeExpansions = tuple(includeExpansions)
         else:
-            self._includedExpansions = ()
+            self._includeExpansions = ()
         # Convert the required lists into tuples
-        for expansionID in self._cfg["expansions"]:
+        for expansionID in self._cfg:
             for key in self.keysConvert2Tuple:
-                converted = tuple(self._cfg["expansions"][expansionID][key])
-                self._cfg["expansions"][expansionID][key] = converted
+                converted = tuple(self._cfg[expansionID][key])
+                self._cfg[expansionID][key] = converted
         # Compute the active expansions
         self._activeExpansions = {}
         for expansionID in self._listPossiblyValidExpansions():
-            self._createExpansion(expansionID)
+            creation_out = self._createExpansion(expansionID)
+            if isinstance(creation_out, expansionsLib.Expansion):
+                self._activeExpansions[expansionID] = creation_out
+            else:
+                raise creation_out
 
         # Connect the signals to the slots
         playersManager.onMadePlayerActive.connect(self._activePlayerAdded)
@@ -287,18 +290,18 @@ class ExpansionsManager:
         return f"ExpansionsManager has {len(self._activeExpansions)} active expansions"
 
     @property
-    def includedExpansions(self):
+    def includeExpansions(self):
         """ Dictionnary of the included expansions. """
-        return self._includedExpansions
+        return self._includeExpansions
 
-    @includedExpansions.setter
-    def includedExpansions(self, newIncluded: tuple[str]):
-        self._includedExpansions = tuple(newIncluded)
+    @includeExpansions.setter
+    def includeExpansions(self, newIncluded: tuple[str]):
+        self._includeExpansions = tuple(newIncluded)
         self._includeChanged()
 
-    @includedExpansions.deleter
-    def includedExpansions(self):
-        self._includedExpansions = ()
+    @includeExpansions.deleter
+    def includeExpansions(self):
+        self._includeExpansions = ()
 
     @property
     def config(self):
@@ -306,7 +309,10 @@ class ExpansionsManager:
         return self._cfg
 
     def _getPlayersFillMissing(self, expansionID):
-        return set(self._cfg["expansions"].get(expansionID, {}).get("players", []))
+        return set(self._cfg.get(expansionID, {}).get("players", []))
+
+    def _getClassFillMissing(self, expansionID):
+        return self._cfg.get(expansionID, {}).get("class", "")
 
     def _listPossiblyValidExpansions(self):
         """
@@ -315,20 +321,28 @@ class ExpansionsManager:
         """
         activePlayers = set(self.playersManager.keys())
         possiblyValidExpansions = [
-            expansionID for expansionID in self._includedExpansions
-            if hasattr(expansionsLib, expansionID) and
+            expansionID for expansionID in self._includeExpansions
+            if hasattr(expansionsLib, self._getClassFillMissing(expansionID)) and
             not self._getPlayersFillMissing(expansionID).isdisjoint(activePlayers)
         ]
         return possiblyValidExpansions
 
     def _createExpansion(self, expansionID):
+        terminalErrors = SystemExit, KeyboardInterrupt, GeneratorExit
         try:
             # Create the expansion
-            expansion = getattr(expansionsLib, expansionID)(expansionID, self)
+            expansionClass = self._getClassFillMissing(expansionID)
+            class_to_create = getattr(expansionsLib, expansionClass)
+            expansion = class_to_create(expansionID, self)
             # Update the lookup
             for player in self._getPlayersFillMissing(expansionID):
-                self._playersLookUp[player].append(expansionID)
+                if player in self._playersLookUp:
+                    self._playersLookUp[player].append(expansionID)
+                else:
+                    self._playersLookUp[player] = [expansionID]
             return expansion
+        except terminalErrors as e:
+            raise e
         except Exception as e:
             return e
 
@@ -339,7 +353,6 @@ class ExpansionsManager:
         # Remove the expansion
         expansion = self._activeExpansions.pop(expansionID)
         expansion.close()
-        del expansion
 
     def _includeChanged(self):
         """
@@ -348,7 +361,7 @@ class ExpansionsManager:
 
         # Compute the expansions involved in the modification
         possiblyValidExpansions = set(self._listPossiblyValidExpansions())
-        previousExpansions = set(self._includedExpansions)
+        previousExpansions = set(self._includeExpansions)
         # Remove irrelevant expansions
         expansionsToRemove = previousExpansions.difference(possiblyValidExpansions)
         for expansionID in expansionsToRemove:
@@ -360,14 +373,14 @@ class ExpansionsManager:
             if isinstance(creation_out, expansionsLib.Expansion):
                 self._activeExpansions[expansionID] = creation_out
             else:
-                print(creation_out)
+                raise creation_out
 
     def _activePlayerAdded(self, playerName):
         # Find the expansions that are to be created
-        possibleAddition = set(self._includedExpansions).difference(self._activeExpansions)
+        possibleAddition = set(self._includeExpansions).difference(self._activeExpansions)
         filteredAddition = [
             expansionID for expansionID in possibleAddition
-            if hasattr(expansionsLib, expansionID) and
+            if hasattr(expansionsLib, self._getClassFillMissing(expansionID)) and
             playerName in self._getPlayersFillMissing(expansionID)
         ]
         # Create the expansions
@@ -376,7 +389,7 @@ class ExpansionsManager:
             if isinstance(creation_out, expansionsLib.Expansion):
                 self._activeExpansions[expansionID] = creation_out
             else:
-                print(creation_out)
+                raise creation_out
 
     def _activePlayerRemoved(self, playerName):
         # Find the expansions that are to be removed
@@ -388,10 +401,10 @@ class ExpansionsManager:
         for expansionID in filteredRemoval:
             self._removeExpansion(expansionID)
 
-    def _errorOccured(self, expansionID):
+    def _midStepError(self, expansionID):
         self._removeExpansion(expansionID)
 
-    def expansionPlayersChanged(self, expansionID, newPlayers):
+    def expansionPlayersChange(self, expansionID, newPlayers):
         """
         Method that allows changing the assigned players of an expansion.
 
@@ -406,7 +419,7 @@ class ExpansionsManager:
         expansionIsActive = expansionID in self._activeExpansions
         activePlayers = set(self.playersManager.keys())
         expansionHasNoPlayers = self._getPlayersFillMissing(expansionID).isdisjoint(activePlayers)
-        expansionDefined = hasattr(expansionsLib, expansionID)
+        expansionDefined = hasattr(expansionsLib, self._getClassFillMissing(expansionID))
         # Update the activation status
         activeChanged = False
         if expansionIsActive and expansionHasNoPlayers:
@@ -417,8 +430,8 @@ class ExpansionsManager:
             if isinstance(creation_out, expansionsLib.Expansion):
                 self._activeExpansions[expansionID] = creation_out
                 activeChanged = True
-            elif isinstance(creation_out, Exception):
-                print(creation_out)
+            else:
+                raise creation_out
         # Update the inverse lookup
         if not activeChanged:
             removedPlayers = set(previousPlayers).difference(newPlayers)
@@ -427,7 +440,7 @@ class ExpansionsManager:
                 self._playersLookUp[playerName].pop(expansionID)
             for playerName in addedPlayers:
                 self._playersLookUp[playerName].append(expansionID)
-    
+
     def lookupPlayer(self, playerName):
         """
         Get a tuple of all expansions available to a player.
@@ -439,21 +452,34 @@ class ExpansionsManager:
             expansionsID (tuple of str): ID of the expansions available to the
                 player
         """
-        return tuple(self._playersLookUp[playerName])
+        return tuple(self._playersLookUp.get(playerName, []))
 
 
 if __name__ == "__main__":
     # Test run to make sure nothing is flagrantly flawed
-    configPath = Path(__file__).parent / "players.json"
-    pm = PlayersManager(playersPath=configPath, gameID="gameID0")
+    configPath = Path(__file__).parent.parent.parent / "players.json"
+    pm = PlayersManager(gameID="gameID0", activePlayers=["Brosef"], playersPath=configPath)
     # Iteration
     for name in pm:
         print(name)
     # Modification of a players data
     brosef = pm["Brosef"]
     brosef.gameSave = [1]
-    print(pm["Brosef"].gameSave)
     brosef.state = ["alive"]
-    # TODO Verify that changing the gameID works as intended
-    # TODO Test out the expansion manager
-    # Implement a way to search within expansions
+
+    # Test run for the expansionsManager
+    # Create the managers
+    configPath = Path(__file__).parent.parent.parent / "players.json"
+    pm = PlayersManager(gameID="gameID0", activePlayers=["Brosef"], playersPath=configPath)
+    em = ExpansionsManager(pm, includeExpansions=["Simple", "SourCandy"])
+
+    # Use the expansion manager to interact with a player using the expansion "Simple"
+    brosefAvailableExpansionsID = em.lookupPlayer("Brosef")
+    if "Simple" in brosefAvailableExpansionsID:
+        # Define some random action
+        vibrateInstead, duration, intensity = False, 1.0, 100
+        action = vibrateInstead, duration, intensity
+        # Perform the action
+        expansionObject = em["Simple"]
+        return_infos = expansionObject(action)
+        assert return_infos["done"], "The step was not successfully completed"